fix infinite loop when gtk_combo_func() returns NULL (bug #75464)

2002-03-19  jacob berkman  <jacob@ximian.com>

	* gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
	gtk_combo_func() returns NULL (bug #75464)

diff --git a/ChangeLog b/ChangeLog
index 49a81ef3f13329af185466804e0f6cf34874d88e..3e0bc047e361bb2f618873edff7f0772b98c994d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2002-03-19  jacob berkman  <jacob@ximian.com>
+
+       * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
+       gtk_combo_func() returns NULL (bug #75464)
+
 2002-03-18  jacob berkman  <jacob@ximian.com>
 
        * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 49a81ef3f13329af185466804e0f6cf34874d88e..3e0bc047e361bb2f618873edff7f0772b98c994d 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,8 @@
+2002-03-19  jacob berkman  <jacob@ximian.com>
+
+       * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
+       gtk_combo_func() returns NULL (bug #75464)
+
 2002-03-18  jacob berkman  <jacob@ximian.com>
 
        * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the

diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index 49a81ef3f13329af185466804e0f6cf34874d88e..3e0bc047e361bb2f618873edff7f0772b98c994d 100644 (file)
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,8 @@
+2002-03-19  jacob berkman  <jacob@ximian.com>
+
+       * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
+       gtk_combo_func() returns NULL (bug #75464)
+
 2002-03-18  jacob berkman  <jacob@ximian.com>
 
        * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index 49a81ef3f13329af185466804e0f6cf34874d88e..3e0bc047e361bb2f618873edff7f0772b98c994d 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,8 @@
+2002-03-19  jacob berkman  <jacob@ximian.com>
+
+       * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
+       gtk_combo_func() returns NULL (bug #75464)
+
 2002-03-18  jacob berkman  <jacob@ximian.com>
 
        * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 49a81ef3f13329af185466804e0f6cf34874d88e..3e0bc047e361bb2f618873edff7f0772b98c994d 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,8 @@
+2002-03-19  jacob berkman  <jacob@ximian.com>
+
+       * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
+       gtk_combo_func() returns NULL (bug #75464)
+
 2002-03-18  jacob berkman  <jacob@ximian.com>
 
        * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 49a81ef3f13329af185466804e0f6cf34874d88e..3e0bc047e361bb2f618873edff7f0772b98c994d 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,8 @@
+2002-03-19  jacob berkman  <jacob@ximian.com>
+
+       * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
+       gtk_combo_func() returns NULL (bug #75464)
+
 2002-03-18  jacob berkman  <jacob@ximian.com>
 
        * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the

diff --git a/gtk/gtkcombo.c b/gtk/gtkcombo.c
index 9fcbf8f55a90d7de4684735d4e1587bfa0ff6684..434941cd712d5f7a9003fbdafdd93a53acf7f1f3 100644 (file)
--- a/gtk/gtkcombo.c
+++ b/gtk/gtkcombo.c
@@ -319,9 +319,9 @@ gtk_combo_find (GtkCombo * combo)
   else
     compare_text = g_utf8_casefold (text, -1);
   
-  clist = GTK_LIST (combo->list)->children;
-
-  while (!found && clist && clist->data)
+  for (clist = GTK_LIST (combo->list)->children;
+       !found && clist;
+       clist = clist->next)
     {
       ltext = gtk_combo_func (GTK_LIST_ITEM (clist->data));
       if (!ltext)
@@ -335,8 +335,6 @@ gtk_combo_find (GtkCombo * combo)
 
       if (!combo->case_sensitive)
        g_free (ltext);
-
-      clist = clist->next;
     }
 
   if (!combo->case_sensitive)